apache / polaris

Apache Polaris, the interoperable, open source catalog for Apache Iceberg
https://polaris.apache.org/
Apache License 2.0
1.13k stars 124 forks source link

Add support to build docker image with eclipselink #227

Closed MonkeyCanCode closed 1 month ago

MonkeyCanCode commented 2 months ago

Description

As https://github.com/apache/polaris/pull/114 added support for building the project with eclipselink via optional flag, this PR is add the same support via optional command line argument to run.sh when using mini-deployment locally.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Default:

yong@DESKTOP:~/polaris(optional_eclipselink)$ bash run.sh
Building Kind Registry...
...
Creating cluster "kind" ...
...
Building polaris image with ECLIPSELINK=false...
...
Applying Kubernetes manifests...
namespace/polaris created
deployment.apps/polaris-deployment created
service/polaris-service created

With optional command line argument:

yong@DESKTOP:~/polaris(optional_eclipselink)$ bash run.sh -e true
Building Kind Registry...
...
Creating cluster "kind" ...
...
Building polaris image with ECLIPSELINK=true...
...
Applying Kubernetes manifests...
namespace/polaris created
deployment.apps/polaris-deployment created
service/polaris-service created

Helper:

xxx@DESKTOP:~/polaris(optional_eclipselink)$ bash run.sh -h
Usage: run.sh [-e true|false] [-h]
  -e    Set the ECLIPSELINK flag (default: false)
  -h    Display this help message

Checklist:

Please delete options that are not relevant.

MonkeyCanCode commented 1 month ago

Anything else needed on this PR?

RussellSpitzer commented 1 month ago

The license check is currently failing, I don't think this should be happening, can you try rebasing and try again?

MonkeyCanCode commented 1 month ago

The license check is currently failing, I don't think this should be happening, can you try rebasing and try again?

yes. Just noticed it. Was fine earlier. Had being a while since I submitted this PR. The PR had being rebased.

adutra commented 1 month ago

The license check is currently failing, I don't think this should be happening, can you try rebasing and try again?

yes. Just noticed it. Was fine earlier. Had being a while since I submitted this PR. The PR had being rebased.

Probably fixed by #266 or #271.

flyrain commented 1 month ago

Thanks @MonkeyCanCode for the PR. Thanks @RussellSpitzer @eric-maynard @collado-mike for the review.