apache / polaris

The interoperable, open source catalog for Apache Iceberg

http://polaris.io/

Apache License 2.0

1.02k stars 99 forks source link

Support buckets containing underscore #263

Closed eric-maynard closed 1 week ago

eric-maynard commented 1 week ago

Description

Currently, we are using URI.getHost to extract the bucket from paths, which can return null unexpectedly when the bucket contains an underscore. This seems to be a known issue.

This PR introduces a thin new utility for extracting the path and adds a test for it.

Fixes #262

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation update
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Added a new suite, StorageUtilTest.

Checklist:

Please delete options that are not relevant.

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

RussellSpitzer commented 1 week ago

Thanks @eric-maynard and thanks @nk1506 for review