apache / polaris

Apache Polaris, the interoperable, open source catalog for Apache Iceberg
https://polaris.apache.org/
Apache License 2.0
1.13k stars 124 forks source link

Sync polaris-server.yml #317

Closed MonkeyCanCode closed 1 month ago

MonkeyCanCode commented 1 month ago

Description

There are couple additional non-optional parameters introduced for the last one month such as "io.factoryType" which can actually cause issue while using Polaris. This PR is to sync what is currently available in https://github.com/apache/polaris/blob/main/polaris-server.yml to the one ref by the helm.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Create a fresh Kind cluster via run.sh then install via Helm to ensure no error raise during install.

Checklist:

Please delete options that are not relevant.

eric-maynard commented 1 month ago

LGTM!

I would actually like us to add more null-checks for things like a missing io, but I tried doing it with Valid and NotNull annotations but didn't have much success.

This doesn't need to block us here. Let's fix the config first.

eric-maynard commented 1 month ago

Thanks for the fix!