apache / polaris

Apache Polaris, the interoperable, open source catalog for Apache Iceberg

https://polaris.apache.org/

Apache License 2.0

1.17k stars 130 forks source link

Refactor PolarisRestCatalogViewIntegrationTest into per cloud provider tests #410

Closed andrew4699 closed 3 weeks ago

andrew4699 commented 3 weeks ago

Description

Test-only change that refactors the PolarisRestCatalogViewIntegrationTest, which runs the Iceberg REST Catalog test suite, into 1 test per cloud provider. There doesn't seem to be a way to do this in 1 file because we inherit the test methods from a superclass.

I'm also interested in doing this for other tests but would like to first gather feedback on this one.

Type of change

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[X] The tests

Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings

andrew4699 commented 3 weeks ago

@eric-maynard Updated it to be multiple files once again and the cloud-provider specific ones will skip the test if the configs aren't specified. This lets people distinguish between tests that were actually ran vs. not.