apache / polaris

Apache Polaris, the interoperable, open source catalog for Apache Iceberg
https://polaris.apache.org/
Apache License 2.0
1.17k stars 130 forks source link

Fix Azure catalog update in CLI by explicitly adding StorageConfigInfo subtype properties #432

Closed dennishuo closed 2 weeks ago

dennishuo commented 2 weeks ago

Description

Fields like externalId, userArn for AWS, tenantId for Azure, gcsServiceAccount were getting clobbered when parsing a JSON response due to the autogenerated model classes not correctly pulling in subtype properties from the API spec.

This caused types with "required" subfields like Azure's tenantId to completely fail parsing when trying to get or update a catalog.

Less noticeable but also bad was that these subtype properties were effectively invisible.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

Please delete options that are not relevant.