apache / pulsar-client-go

Apache Pulsar Go Client Library
https://pulsar.apache.org/
Apache License 2.0
659 stars 336 forks source link

[pulsaradmin] Add GetAllSchemas command #1289

Closed calindima closed 1 month ago

calindima commented 1 month ago

Didn't create an issue but I can if that's necessary, otherwise I'll write the details in this PR.

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

We actively use pulsarctl which has a dependency on this library. We have a use case where we want to interogate the SchemaRegistry to retrieve a history of schema versions and observe schema evolution for topics with higher retention (e.g. infinite retention, >6mo retention etc.).

Modifications

Describe the modifications you've done.

The PR only contains additions such as:

Verifying this change

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

Documentation

Just let me know if there's any documentation I should update - I only added a godoc comment to the new method

calindima commented 1 month ago

Thanks for running the workflows @crossoverJie. I fixed the linter error but the failed integration test is not related to anything changed in this PR as far as I can tell.

crossoverJie commented 1 month ago

Thanks for running the workflows @crossoverJie. I fixed the linter error but the failed integration test is not related to anything changed in this PR as far as I can tell.

Yes, I have approved it. Thank you for your contribution

calindima commented 1 month ago

Thanks for the quick feedback. Any idea in which release will this be included?