[feat] Add listenerName to client config

roryschadler commented 7 months ago

Fixes #214

Motivation

This library doesn't provide a way to pass a custom listener name to a Pulsar client, which is necessary if you have multiple advertised listeners and want to hit the non-default one: https://pulsar.apache.org/docs/next/concepts-multiple-advertised-listeners/

Modifications

After https://github.com/apache/pulsar-client-cpp/pull/370, getListener and setListener are now exposed in the C API, and can be used by this library as well.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

added listenerName to e2e tests where necessary (uses first advertisedListener by default)

Documentation

[ ] doc-required (Your PR needs to update docs and you will update later)
[ ] doc-not-needed (Please explain why)
[ ] doc (Your PR contains doc changes)
[ ] doc-complete (Docs have been already added)

shibd commented 7 months ago

@roryschadler hi, I'm doing release v1.11.0, Do you want to include it in v1.11.0?

roryschadler commented 7 months ago

@shibd yes, that would be great! Thanks @merlimat for the quick review. It looks like all the checks are green (~except for the ARM64 linux_glibc check, as of now, it's still running~ all are green). If you're good to go with it, I'd love to include it!

apache / pulsar-client-node