fix: Compile glibc binaries using node:buster instead of centos7 - Githubissues

apache / pulsar-client-node

Apache Pulsar NodeJS Client

https://pulsar.apache.org/

Apache License 2.0

148 stars 86 forks source link

fix: Compile glibc binaries using node:buster instead of centos7 #389

Closed shibd closed 4 months ago

shibd commented 4 months ago

Motivation

Compile glibc binaries using node:buster instead of centos7 for two reasons:

Binaries compiled with centos7 may not be compatible with the node:buster (glibc) environment.
Centos7 has reached its End of Life (EOL)."

Modifications

Use node:${NODE_VERSION}-buster to build glibc-type binaries.

Verifying this change

Multi linux_glibc oss verify passed. https://github.com/apache/pulsar-client-node/blob/13c285989743aa37e5c2b2909fadef0d343b228e/.github/workflows/ci-pr-validation.yml#L173-L179
Self-release build passed and verified passed. https://github.com/shibd/pulsar-client-node/releases/tag/v1.11.0-fix.1 You can install it by: npm install shibaodi-pulsar-client@1.11.0-fix.1

Documentation

[ ] doc-required (Your PR needs to update docs and you will update later)
[x] doc-not-needed (Please explain why)
[ ] doc (Your PR contains doc changes)
[ ] doc-complete (Docs have been already added)