Currently the acknowledge and acknowledge_cumulative methods are all asynchronous. Even if any error happened, no exception would be raised. For example, when acknowledging cumulatively on a consumer whose consumer type is Shared or KeyShared, no error happens.
Modifications
Change these methods to synchronous and raise exceptions if the acknowledgment failed.
Add PulsarTest.test_acknowledge_failed to test these failed cases.
Improve the documents to describe which exceptions could be raised in which cases.
BewareMyPower
commented
1 year ago
Fixes https://github.com/apache/pulsar-client-python/issues/114
Motivation
Currently the
acknowledgeandacknowledge_cumulativemethods are all asynchronous. Even if any error happened, no exception would be raised. For example, when acknowledging cumulatively on a consumer whose consumer type is Shared or KeyShared, no error happens.Modifications
PulsarTest.test_acknowledge_failedto test these failed cases.