apache / pulsar-client-python

Apache Pulsar Python client library
https://pulsar.apache.org/
Apache License 2.0
49 stars 38 forks source link

Add type annotations for enum parameters in methods #169

Closed shibd closed 7 months ago

shibd commented 7 months ago

Motivation

This PR adds type annotations for enum parameters in various methods in the pulsar-client-python package. The goal of these changes is to improve the clarity and readability of the code, and to provide better hints to developers about the expected types of the parameters.

Modifications

The following methods have been modified to include type annotations for their enum parameters:

For example, in the Client.create_producer method, the compression_type parameter was previously defined as compression_type=CompressionType.NONE, but now it is defined as compression_type: CompressionType = CompressionType.NONE.

Benefits

The addition of these type annotations will make the code easier to read and understand. It will also provide better hints to developers about the expected types of the parameters, which could help prevent bugs and errors.

Please review and provide feedback.