apache / pulsar-client-python

Apache Pulsar Python client library
https://pulsar.apache.org/
Apache License 2.0
49 stars 38 forks source link

Fix negative acknowledge on a message ID does not work #180

Closed BewareMyPower closed 6 months ago

BewareMyPower commented 6 months ago

Fixes https://github.com/apache/pulsar-client-python/issues/178

Motivation

https://github.com/apache/pulsar-client-python/pull/121 introduces a regression that when negative_acknowledge accepts a message ID, the underlying acknowledgeAsync method will be called.

Modifications

Fix the Consumer_negative_acknowledge_message_id method and add the test for negative acknowledging message IDs in test_redelivery_count.