search

apache / pulsar-client-python

Apache Pulsar Python client library
https://pulsar.apache.org/
Apache License 2.0
49 stars 38 forks source link

Fix incorrect logs when a message failed to be decoded with the writer schema #200

Closed BewareMyPower closed 4 months ago

BewareMyPower commented 5 months ago

Motivation

See https://github.com/apache/pulsar-client-python/blob/f9b2d168ae85f289d6ee043cd81791d569ba8844/pulsar/schema/schema_avro.py#L92C32-L92C69

When self._decode_bytes(msg.data(), writer_schema) failed, the error log is still Failed to get schema info, which is confusing.

Modifications

Modify the error message. Even if it failed at self._get_writer_schema(topic, version), there would still be error logs from the C++ client.

BewareMyPower commented 5 months ago

It seems the main branch is broken. I will fix it first.