apache / pulsar-helm-chart

Official Apache Pulsar Helm Chart
https://pulsar.apache.org/
Apache License 2.0
212 stars 224 forks source link

pulsar-proxy: tls Certname #527

Open cccdemon opened 2 months ago

cccdemon commented 2 months ago

Is your feature request related to a problem? Please describe. When you want to use a valid / signed certificate for pulsar-proxy, the helm charts do not use the certname you entered in the values file: Example: proxy: enabled: true cert_name: my-valid-certificate # use this certname createCert: false # set to false if you want to use an existing certificate

Results in certificate name within the Proxy as "pulsar-my-valid-certificate"

Describe the solution you'd like just use the cert_name i`ve entered

Describe alternatives you've considered remove the option of "using the releasename as prefix"

Additional context File: proxy-statefulset.yaml

{{- if .Values.tls.proxy.createCert }}
secretName: "{{ .Release.Name }}-{{ .Values.tls.proxy.cert_name }}"
{{- else }}
secretName: "{{ .Values.tls.proxy.cert_name }}"
{{- end }}
lhotari commented 2 months ago

@cccdemon Sounds like a useful improvement. Would you like to contribute a pull request? This Helm chart is community maintained so pull requests are preferred so that we can improve the chart together over time.

cccdemon commented 2 months ago

@lhotari never did that, but I will give it a try :-)

lhotari commented 1 month ago

@cccdemon There's #523 with a related change. That has been merged.