[Bug] V4.0.1 wireshark lua script will crash

labuladong commented 1 year ago

Search before asking

[X] I searched in the issues and found nothing similar.

Version

Master version of Pulsar.

Version 4.0.1 (v4.0.1-0-ge9f3970b1527) of Wireshark.

Minimal reproduce step

https://github.com/apache/pulsar/pull/13564 add a lua script to parse Pulsar command, which is great.

I follow the step here.

First I put PulsarApi.proto file to a folder and set protobuf search path in wireshark:

Then I copy lua script to plugin folder:

Restart wireshark and start a pulsar standalone, I can see ping/pong message on port 6650:

Now, I create a producer or consumer to send or consume messages.

What did you expect to see?

Wireshark should parse other protobuf packages just like ping/pong.

What did you see instead?

Wireshark will crash.

Anything else?

No response

Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

labuladong commented 1 year ago

cc @leizhiyuan

leizhiyuan commented 1 year ago

cc @leizhiyuan

https://github.com/apache/pulsar/pull/15029

I fixed some issue, but need someone's review.

you can give a try

but If it is not ok, please upload your pcap file , I will upgrade my wireshark(I use 4.0.0 (v4.0.0-0-g0cbe09cd796b).) and test it again

labuladong commented 1 year ago

Thanks, I installed Wireshark V3.6.9, and this issue disappeared. You can try Wireshark 4.0.1 and just create a simple producer, this issue will occur.

leizhiyuan commented 1 year ago

ok,I will check it ,maybe there has an exception in wireshark 4.0.1 or some api can not used in higher version

github-actions[bot] commented 1 year ago

The issue had no activity for 30 days, mark with Stale label.

apache / pulsar