Open michaeljmarshall opened 1 year ago
@lhotari - I took a quick look at https://github.com/apache/pulsar/blob/cfe643bc9d45e74271df6f4d16d46087572e285b/src/rename-netty-native-libs.sh, which needs to be updated to fix this. Do you know if we can simply relocate the files that have netty in their name, or do we need to enumerate each file? Thanks!
The issue had no activity for 30 days, mark with Stale label.
What do you mean by "relocated" here? IIRC Netty searches under /native
folder and this logic has nothing to do with relocated.
Does this layout cause any real-world issue?
The issue had no activity for 30 days, mark with Stale label.
Does this layout cause any real-world issue?
I haven't confirmed, but I assume it just leads to slower execution.
The issue had no activity for 30 days, mark with Stale label.
Search before asking
Version
All of them
Minimal reproduce step
Download a
pulsar-client-all.jar
, then view theMETA-INF/native/
directory.What did you expect to see?
Properly relocated binaries.
What did you see instead?
Anything else?
See https://github.com/apache/pulsar/pull/18646#pullrequestreview-1201600977 for more context.
Are you willing to submit a PR?