[feat][broker] PIP-264: Add OpenTelemetry broker replicator metrics - Githubissues

apache / pulsar

Apache Pulsar - distributed pub-sub messaging system

https://pulsar.apache.org/

Apache License 2.0

13.94k stars 3.53k forks source link

[feat][broker] PIP-264: Add OpenTelemetry broker replicator metrics #22972

Closed dragosvictor closed 1 week ago

dragosvictor commented 1 week ago

Motivation

Adds existing broker replicator metrics (documented by https://pulsar.apache.org/docs/next/reference-metrics/#replication-metrics-1) to the OpenTelemetry pipeline.

Modifications

Adds the replication metrics, as described by https://github.com/apache/pulsar-site/pull/926/, to the collector runs.
Renamed Replicator#getStats to Replicator#computeStats, as it modifies the underlying object in the process. Added a simple getter Replicator#getStats for the object itself. This helps clarify the intent of the methods.

Verifying this change

[x] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added test ReplicatorTest#testReplicationMetrics
Updated test ReplicatorTest#testResumptionAfterBacklogRelaxed

Does this pull request potentially affect one of the following parts:

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[x] The metrics: As described in https://github.com/apache/pulsar-site/pull/926
[ ] Anything that affects deployment

Documentation

[ ] doc
[x] doc-required https://github.com/apache/pulsar-site/pull/926
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/dragosvictor/pulsar/pull/26