[fix][broker] Fix NPE calling PulsarService.getBrokerId() in checkTopicNsOwnership method during broker startup - Githubissues

apache / pulsar

Apache Pulsar - distributed pub-sub messaging system

https://pulsar.apache.org/

Apache License 2.0

14.15k stars 3.57k forks source link

[fix][broker] Fix NPE calling PulsarService.getBrokerId() in checkTopicNsOwnership method during broker startup #22981

Closed lhotari closed 3 months ago

lhotari commented 3 months ago

Fixes #22975

Motivation

PulsarService.getBrokerId() will fail with NPE if it's called before the broker has been started.

Modifications

don't use brokerId in log message in org.apache.pulsar.broker.service.BrokerService#checkTopicNsOwnership method since the method might get called in the startup sequence, before brokerId is available.

Additional Context

There's a more complete fix to address the root cause, that's #22977.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

lhotari commented 3 months ago

This PR is now obsolete after #22977 has been merged.