search

apache / pulsar

Apache Pulsar - distributed pub-sub messaging system
https://pulsar.apache.org/
Apache License 2.0
13.94k stars 3.53k forks source link

[feat][broker] PIP-264: Add OpenTelemetry managed ledger metrics #22987

Open dragosvictor opened 5 days ago

dragosvictor commented 5 days ago

PIP-264

Motivation

Adds Managed Ledger metrics, as currently described here, to the OpenTelemetry pipeline.

Modifications

Verifying this change

This change modified tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: https://github.com/dragosvictor/pulsar/pull/35

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 98.03922% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.45%. Comparing base (bbc6224) to head (97db472). Report is 427 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/22987/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #22987 +/- ## ============================================ - Coverage 73.57% 73.45% -0.12% - Complexity 32624 33287 +663 ============================================ Files 1877 1909 +32 Lines 139502 143054 +3552 Branches 15299 15578 +279 ============================================ + Hits 102638 105080 +2442 - Misses 28908 29943 +1035 - Partials 7956 8031 +75 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22987/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.74% <98.03%> (+3.16%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.75% <47.05%> (+0.42%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.47% <98.03%> (-0.37%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/apache/pulsar/pull/22987?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...he/bookkeeper/mledger/ManagedLedgerAttributes.java](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&filepath=managed-ledger%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbookkeeper%2Fmledger%2FManagedLedgerAttributes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9NYW5hZ2VkTGVkZ2VyQXR0cmlidXRlcy5qYXZh) | `100.00% <100.00%> (ø)` | | | [...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&filepath=managed-ledger%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbookkeeper%2Fmledger%2Fimpl%2FManagedLedgerFactoryImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJGYWN0b3J5SW1wbC5qYXZh) | `82.03% <100.00%> (+0.64%)` | :arrow_up: | | [...ookkeeper/mledger/impl/ManagedLedgerMBeanImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&filepath=managed-ledger%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbookkeeper%2Fmledger%2Fimpl%2FManagedLedgerMBeanImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJNQmVhbkltcGwuamF2YQ==) | `90.34% <100.00%> (+0.63%)` | :arrow_up: | | [.../mledger/impl/OpenTelemetryManagedLedgerStats.java](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&filepath=managed-ledger%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbookkeeper%2Fmledger%2Fimpl%2FOpenTelemetryManagedLedgerStats.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL09wZW5UZWxlbWV0cnlNYW5hZ2VkTGVkZ2VyU3RhdHMuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [.../pulsar/opentelemetry/OpenTelemetryAttributes.java](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&filepath=pulsar-opentelemetry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fopentelemetry%2FOpenTelemetryAttributes.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLW9wZW50ZWxlbWV0cnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9vcGVudGVsZW1ldHJ5L09wZW5UZWxlbWV0cnlBdHRyaWJ1dGVzLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...a/org/apache/bookkeeper/mledger/ManagedLedger.java](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&filepath=managed-ledger%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbookkeeper%2Fmledger%2FManagedLedger.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9NYW5hZ2VkTGVkZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/22987?src=pr&el=tree&filepath=managed-ledger%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbookkeeper%2Fmledger%2Fimpl%2FManagedLedgerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL01hbmFnZWRMZWRnZXJJbXBsLmphdmE=) | `81.33% <80.00%> (+0.67%)` | :arrow_up: | ... and [476 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22987/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)