search

apache / pulsar

Apache Pulsar - distributed pub-sub messaging system
https://pulsar.apache.org/
Apache License 2.0
14.26k stars 3.59k forks source link

[fix][test] Fix NonDurableSubscriptionTest.testInitReaderAtSpecifiedP… #23293

Closed summeriiii closed 2 weeks ago

summeriiii commented 2 months ago

Motivation

The comments and code are inconsistent in the test NonDurableSubscriptionTest.testInitReaderAtSpecifiedPosition, some are comments not correct while others are code not correct. This issue was introduced by https://github.com/apache/pulsar/pull/21248.

Modifications

fix the inconsistent between comments and code in the test NonDurableSubscriptionTest.testInitReaderAtSpecifiedPosition

Documentation

Matching PR in forked repository

PR in forked repository:

summeriiii commented 2 months ago

@poorbarcode PTAL, thx

summeriiii commented 1 month ago

@poorbarcode the test failed before and I rebased master, could you help to trigger the workflow?

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.35%. Comparing base (bbc6224) to head (faf1521). Report is 702 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/23293/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/23293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #23293 +/- ## ============================================ + Coverage 73.57% 74.35% +0.77% - Complexity 32624 34428 +1804 ============================================ Files 1877 1943 +66 Lines 139502 147045 +7543 Branches 15299 16205 +906 ============================================ + Hits 102638 109334 +6696 - Misses 28908 29281 +373 - Partials 7956 8430 +474 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23293/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23293/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.32% <ø> (+2.74%)` | :arrow_up: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/23293/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.40% <ø> (+0.07%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23293/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.72% <ø> (+0.88%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [see 653 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23293/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)