[Bug][Test] NonPersistentTopicMessagingTest does not cover Non-Persistent topics - Githubissues

apache / pulsar

Apache Pulsar - distributed pub-sub messaging system

https://pulsar.apache.org/

Apache License 2.0

14.27k stars 3.59k forks source link

[Bug][Test] NonPersistentTopicMessagingTest does not cover Non-Persistent topics #23541

Open heesung-sn opened 3 weeks ago

heesung-sn commented 3 weeks ago

Search before asking

[X] I searched in the issues and found nothing similar.

Read release policy

[X] I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

4.0

Minimal reproduce step

run NonPersistentTopicMessagingTest

What did you expect to see?

NonPersistentTopicMessagingTest should use non-persistent topics

What did you see instead?

NonPersistentTopicMessagingTest uses persistent topics

Anything else?

https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/messaging/MessagingBase.java#L57

https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/messaging/MessagingBase.java#L65

In the above test code, we don't pass the isPersistent input when generating topic names.

If I fix the above code and run the test, the test fails. There might be some bugs around here.

Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

heesung-sn commented 3 weeks ago

In fact, there are other tests impacted by this bug.

NonDurableConsumerMessagingTest
ReaderMessagingTest