[ISSUE #1106] Send retry as a normal message when sendMessageBack fails - Githubissues

apache / rocketmq-client-go

Apache RocketMQ go client

https://rocketmq.apache.org/

Apache License 2.0

1.28k stars 409 forks source link

[ISSUE #1106] Send retry as a normal message when sendMessageBack fails #1107

Closed redlsz closed 3 months ago

redlsz commented 8 months ago

What is the purpose of the change

fix #1106

Brief changelog

Send retry as a normal message when sendMessageBack fails. (Refer to Java SDK)

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

leizhiyuan commented 3 months ago

@lizhanhui @francisoliverlee @lizhimins

Please review it when you have time. We have already conducted the test.

lizhanhui commented 3 months ago

@leizhiyuan The behavior is aligning with Java counterparts, merged.