apache / rocketmq-client-go

Apache RocketMQ go client
https://rocketmq.apache.org/
Apache License 2.0
1.31k stars 423 forks source link

[ISSUE #933] fix retry topic and namespace topic block #934

Closed 0daypwn closed 1 year ago

0daypwn commented 2 years ago

What is the purpose of the change

close #933

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

0daypwn commented 2 years ago

map is not thread safe, so should add RWMutex. The design is too complicated. Maybe there's a better way?

ShannonDing commented 2 years ago

@0daypwn , hi, it seems have conflicts after PR #944 merged, could you pls fix it and and have a test after the crCh initialized?

0daypwn commented 2 years ago

The purpose of these two is the same.

but the pc.crCh Map may be read and written concurrently in two places

@ShannonDing @NeonToo

maixiaohai commented 2 years ago
截屏2022-10-24 20 42 32

@0daypwn pls resolve the conflicts first