[ISSUE #953] fix limiter with goroutine cover - Githubissues

apache / rocketmq-client-go

Apache RocketMQ go client

https://rocketmq.apache.org/

Apache License 2.0

1.31k stars 423 forks source link

[ISSUE #953] fix limiter with goroutine cover #952

Closed maqingxiang closed 2 years ago

maqingxiang commented 2 years ago

What is the purpose of the change

add gotorutine restriction for limiter, avoid creating goroutine excessively.

Brief changelog

push_consumer.go

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

maqingxiang commented 2 years ago

@ShannonDing @superhx @NeonToo 帮忙看下，是否可以修改为在并发控制的范围内进行自定义流控，避免无限制创建 goroutine 的风险