apache / rocketmq-client-go

Apache RocketMQ go client
https://rocketmq.apache.org/
Apache License 2.0
1.31k stars 424 forks source link

empty subcribed topic is allowed to start #969

Closed NeonToo closed 1 year ago

NeonToo commented 1 year ago

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

codecov-commenter commented 1 year ago

Codecov Report

Merging #969 (28c9461) into master (0742aac) will decrease coverage by 0.06%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage   23.38%   23.32%   -0.07%     
==========================================
  Files          52       52              
  Lines        7247     7267      +20     
==========================================
  Hits         1695     1695              
- Misses       5320     5340      +20     
  Partials      232      232              
Impacted Files Coverage Δ
consumer/push_consumer.go 12.52% <0.00%> (-0.03%) :arrow_down:
internal/model.go 53.26% <0.00%> (-5.08%) :arrow_down:
internal/utils/set.go 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more