apache / rocketmq-exporter

Apache RocketMQ Prometheus Exporter
https://rocketmq.apache.org/
Apache License 2.0
294 stars 171 forks source link

fix dockerfile base image manifest unknown #167

Open MartinDai opened 8 months ago

MartinDai commented 8 months ago

What is the purpose of the change

fix dockerfile base image manifest unknown

Brief changelog

fix dockerfile base image manifest unknown

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

francisoliverlee commented 5 months ago

thank you to fix this important issue. and there still 2 fix should be done

  1. add final name in pom.xml in build tag
  2. ADD rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar rocketmq-exporter.jar in docker file must depends on final-name in pom.xml
MartinDai commented 5 months ago

thank you to fix this important issue. and there still 2 fix should be done

  1. add final name in pom.xml in build tag
  2. ADD rocketmq-exporter-0.0.2-SNAPSHOT-exec.jar rocketmq-exporter.jar in docker file must depends on final-name in pom.xml

@francisoliverlee done