search

apache / rocketmq-flink

RocketMQ integration for Apache Flink. This module includes the RocketMQ source and sink that allows a flink job to either write messages into a topic or read from topics in a flink job.
https://rocketmq.apache.org/
Apache License 2.0
139 stars 88 forks source link

[Feature] Support rich initialization modes of RocketMQ source #62

Closed deemogsw closed 1 year ago

deemogsw commented 1 year ago

1.Add rich initialization modes those are similar to kafka-connector 2.Add metrics in source phase link to #59 @SteNicholas could you review the code?

codecov-commenter commented 1 year ago

Codecov Report

Merging #62 (946de42) into main (460694b) will increase coverage by 1.30%. The diff coverage is 34.73%.

@@             Coverage Diff              @@
##               main      #62      +/-   ##
============================================
+ Coverage     27.20%   28.50%   +1.30%     
- Complexity      149      164      +15     
============================================
  Files            59       62       +3     
  Lines          2470     2529      +59     
  Branches        268      269       +1     
============================================
+ Hits            672      721      +49     
- Misses         1732     1741       +9     
- Partials         66       67       +1
Impacted Files Coverage Δ
...rialization/SimpleStringDeserializationSchema.java 25.00% <25.00%> (ø)
...rocketmq/flink/legacy/common/util/MetricUtils.java 2.94% <25.00%> (+2.94%) :arrow_up:
.../rocketmq/flink/legacy/RocketMQSourceFunction.java 9.55% <25.33%> (+9.55%) :arrow_up:
...link/legacy/common/config/OffsetResetStrategy.java 100.00% <100.00%> (ø)
...cketmq/flink/legacy/common/config/StartupMode.java 100.00% <100.00%> (ø)
...e/rocketmq/flink/legacy/common/util/TestUtils.java 72.72% <100.00%> (+72.72%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

deemogsw commented 1 year ago

Thanks for @deemogsw the feature contribution. I left some comments for the feature support of RocketMQSourceFunction. Could you please also support this feature for the RocketMQSource?

BTW, could you please take a look at the failure of the CI?

Thanks for comments. I'm glad to perfect those features for new source interface.I will open a new issue for RocketMQSource or commit to this pull request in a few days.Which do you think is better.

deemogsw commented 1 year ago

Thanks for @deemogsw updates. I left the minor comments for the comments of the class. PTAL.

BTW, the feature support for the new Source interface could be created another pull request.

done. Besides I have opened issue #63 ,please assign it to me.Thanks