search

apache / rocketmq-operator

Apache RocketMQ Operator
https://rocketmq.apache.org/
Apache License 2.0
314 stars 127 forks source link

Broker does not support initiating registration to a newly created nameserver #52

Open stheart opened 4 years ago

stheart commented 4 years ago

Question

we use rocketmq-operator to deploy in k8s,found that when up-scale name server cluster,broker will restart one by one, this will put extra pressure on the cluster,and restart may fail.

I check the broker code, it seems the broker get name server address at the begining and don't support refresh name server address list automatic when add name server pod, so operator has to restart all broker,is this right?

FEATURE REQUEST

broker support register to new name server pod,don't need to restart. eg: 1.broker provide api to refresh name server address 2.rocketmq-operator push the new name server address to broker api when add new nameserver pod.

liuruiyiyang commented 4 years ago

Yes, the broker does not support hot-change the name server IP list yet (at lease in version 4.5.0), so currently our solution is to restart them one by one. And users can choose not to restart in Broker CR by setting allowRestart. In fact we have some discussion on this, checkout RocketMQ PR#1458 https://github.com/apache/rocketmq/pull/1458 . We will continue to look at this issue.