search

apache / rocketmq-schema-registry

Apache RocketMQ Schema Registry
https://rocketmq.apache.org/
31 stars 20 forks source link

support JSON serde #41

Closed humkum closed 2 years ago

humkum commented 2 years ago

close #29

codecov-commenter commented 2 years ago

Codecov Report

Merging #41 (62e0514) into main (a689b4d) will decrease coverage by 0.65%. The diff coverage is 1.72%.

@@            Coverage Diff             @@
##              main     #41      +/-   ##
==========================================
- Coverage     9.58%   8.92%   -0.66%     
  Complexity      25      25              
==========================================
  Files           37      40       +3     
  Lines          772     829      +57     
  Branches        40      42       +2     
==========================================
  Hits            74      74              
- Misses         692     749      +57     
  Partials         6       6
Impacted Files Coverage Δ
...a/registry/client/serde/json/JsonDeserializer.java 0.00% <0.00%> (ø)
...q/schema/registry/client/serde/json/JsonSerde.java 0.00% <0.00%> (ø)
...ema/registry/client/serde/json/JsonSerializer.java 0.00% <0.00%> (ø)
...ema/registry/client/serde/avro/AvroSerializer.java 72.72% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

MatrixHB commented 2 years ago

We still need compatibility validation for JSON type. Would you like to complete it with another pr? @humkum

humkum commented 2 years ago

We still need compatibility validation for JSON type. Would you like to complete it with another pr? @humkum

Yes,I just temporarily provide a usable version, I also considered there should be compatibility validation. I'll complete that.