search

apache / rocketmq-streams

Apache rocketmq
https://rocketmq.apache.org/
Apache License 2.0
171 stars 82 forks source link

There's no difference between the implementation for the two `count` functions of `GroupedStreamImpl` #299

Open elenacliu opened 1 year ago

elenacliu commented 1 year ago

Maybe the second count function of which declaration is public <OUT> GroupedStream<K, Integer> count(SelectAction<OUT, V> selectAction) may do count operation based on whether the key exists or not?

ni-ze commented 1 year ago

count(SelectAction<OUT, V> selectAction) is plan to calculate the count of the special key. But the implementation is be forgotten.

can you submit a pr to make it correct?

elenacliu commented 1 year ago

count(SelectAction<OUT, V> selectAction) is plan to calculate the count of the special key. But the implementation is be forgotten.

can you submit a pr to make it correct?

sure, I'll do it in the following days.