Open marcingrzejszczak opened 1 year ago
I've added a draft PR here https://github.com/apache/rocketmq/pull/7248
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
Can we keep this alive or, which is better, review and merge the PR?
Is Your Feature Request Related to a Problem?
I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with @shakuzen and @jonatan-ivanov).
Micrometer Observation is part of the Micrometer 1.10 release and Micrometer Tracing is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit).
Since this project supports OpenTracing that is deprecated I was curious if there's interest in adding Micrometer Observation support so that except for metrics, spans could be created and tracing context propagation could happen too. Via Micrometer Tracing one can use OpenTelemetry or OpenZipkin Brave Tracer, but with the handler mechanism the possibilities are endless :)
If there's such interest we could provide a PR to add support for that.
Describe the Solution You'd Like
I would add a PR that uses Micrometer Observation to instrument the project
Describe Alternatives You've Considered
In order to have both metrics and tracing one would need to use the deprecated opentracing instrumentation + metrics instrumentation. With Micrometer Observation you instrument once and you can get metrics, tracing, logging etc. just by configuring it
Additional Context
No response