search

apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.
https://rocketmq.apache.org/
Apache License 2.0
21.22k stars 11.68k forks source link

[Feature] Why not completely remove fastjson 1.x.x? #8572

Open iamlinhui opened 2 months ago

iamlinhui commented 2 months ago

Is Your Feature Request Related to a Problem?

org.apache.rocketmq:rocketmq-common:5.3.0 -- com.alibaba:fastjson:1.2.83 -- com.alibaba.fastjson2:fastjson2:2.0.51

why not completely remove fastjson 1.2.83，and lower versions cannot be exclusion

Describe the Solution You'd Like

completely remove fastjson 1.2.83

Describe Alternatives You've Considered

make the serialization method plugin like and load it by checking if the class exists

Additional Context

No response

leizhiyuan commented 2 months ago

you can see https://github.com/apache/rocketmq/pull/6583#issuecomment-1505108339

The unit test only covers a very small part of the usage, aka, having namesrv generate valid JSON when answering route of topic query.

Actually, there are a few places, for example, storing consume-offset where incompatible JSON is used since key of the entry is not string. Prior blocking issues have to be fixed first.