apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.
https://rocketmq.apache.org/
Apache License 2.0
21.13k stars 11.64k forks source link

[ISSUE #8599] Fix send fail with receiving GO_AWAY when rolling update proxy and add channel id in logs #8685

Closed qianye1001 closed 2 weeks ago

qianye1001 commented 2 weeks ago

Which Issue(s) This PR Fixes

Fixes #8599

  1. Reconnect condition may not be satisfied when rolling update proxy because of the reconnect interval 60 seconds
  2. Sending retry request without extFields may fail

Brief Description

  1. Fix send fail with receiving GO_AWAY when rolling update proxy
  2. Add channel id in logs
  3. Send retry request with extFields when receiving GO_AWAY

How Did You Test This Change?

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (4c51706) to head (de3187a). Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingClient.java 25.00% 19 Missing and 2 partials :warning:
...rocketmq/remoting/netty/NettyRemotingAbstract.java 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #8685 +/- ## ============================================= + Coverage 47.27% 47.49% +0.22% - Complexity 11488 11533 +45 ============================================= Files 1277 1277 Lines 89425 89455 +30 Branches 11502 11505 +3 ============================================= + Hits 42272 42486 +214 + Misses 41948 41745 -203 - Partials 5205 5224 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qianye1001 commented 2 weeks ago

@drpmma