search

apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.
https://rocketmq.apache.org/
Apache License 2.0
21.26k stars 11.7k forks source link

[ISSUE #8691] Fix PR-CI errors #8692

Closed yx9o closed 2 months ago

yx9o commented 2 months ago

Fixes #8691 .

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.47%. Comparing base (00d5047) to head (251e10b). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #8692 +/- ## ============================================= - Coverage 47.54% 47.47% -0.08% + Complexity 11547 11523 -24 ============================================= Files 1277 1277 Lines 89449 89455 +6 Branches 11504 11505 +1 ============================================= - Hits 42532 42470 -62 - Misses 41711 41763 +52 - Partials 5206 5222 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

francisoliverlee commented 2 months ago

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024, it suggests to use v4 on https://github.com/actions/upload-artifact image

yx9o commented 2 months ago

Thanks for your review, can I upgrade all actions/upload-artifact@v3 to actions/upload-artifact@v4?

lizhimins commented 2 months ago

Suggest use v4

yx9o commented 2 months ago

All have been upgraded to actions/upload-artifact@v4, please review, thank you.