apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.
https://rocketmq.apache.org/
Apache License 2.0
21.25k stars 11.7k forks source link

[Bug] Some response codes are duplicated #8719

Open absolute8511 opened 1 month ago

absolute8511 commented 1 month ago

Before Creating the Bug Report

Runtime platform environment

All

RocketMQ version

5.x

JDK Version

Any

Describe the Bug

as below in https://github.com/apache/rocketmq/blob/6024db77f59aa5810d47914edea9b8f0ae68b693/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/ResponseCode.java#L75 the codes with 209,210,211 are the same for different means.

public static final int UPDATE_AND_CREATE_ACL_CONFIG_FAILED = 209;

    public static final int DELETE_ACL_CONFIG_FAILED = 210;

    public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG_FAILED = 211;

    public static final int POLLING_FULL = 209;

    public static final int POLLING_TIMEOUT = 210;

    public static final int BROKER_NOT_EXIST = 211;

Steps to Reproduce

no need

What Did You Expect to See?

response code should be unique by mean.

What Did You See Instead?

response code is used several times.

Additional Context

No response

lizhimins commented 1 month ago

历史问题,在不同的 rpc 所以功能上不影响,修改的话要注意兼容性