search

apache / rocketmq

Apache RocketMQ is a cloud native messaging and streaming platform, making it simple to build event-driven applications.
https://rocketmq.apache.org/
Apache License 2.0
21.26k stars 11.7k forks source link

[ISSUE #8728] Add more test coverage for TopicQueueMappingCleanService #8729

Open yx9o opened 1 month ago

yx9o commented 1 month ago

Fixes #8728 .

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.55%. Comparing base (945e7ea) to head (3a668ea).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #8729 +/- ## ============================================= + Coverage 47.53% 47.55% +0.02% + Complexity 11551 11548 -3 ============================================= Files 1279 1279 Lines 89562 89562 Branches 11516 11516 ============================================= + Hits 42569 42590 +21 + Misses 41773 41719 -54 - Partials 5220 5253 +33 ``` | [Flag](https://app.codecov.io/gh/apache/rocketmq/pull/8729/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/apache/rocketmq/pull/8729/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.55% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yx9o commented 1 month ago

Hi @ShannonDing , please help review, thank you.

yx9o commented 3 weeks ago

Hi @RongtongJin , please help review, thank you.