apache / royale-asjs

Apache Royale ASJS
Apache License 2.0
372 stars 116 forks source link

DateChooser with height of 200 or so hides last row of dates #19

Open justinmclean opened 7 years ago

justinmclean commented 7 years ago

If you set the height on a DataChooser to be under 230 pixels the last row of the DateChooser may be hidden.

Code to reproduce:

<?xml version="1.0" encoding="utf-8"?>
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
                xmlns:js="library://ns.apache.org/flexjs/basic">
    <js:valuesImpl>
        <js:SimpleCSSValuesImpl/>
    </js:valuesImpl>

    <js:initialView>
        <js:View>
            <js:Group id="content">
                <js:beads>
                    <js:VerticalLayout />
                </js:beads>
                <js:DateChooser width="300" height="200" />
                <js:DateChooser width="300" height="230" />
            </js:Group>
        </js:View>
    </js:initialView>

</js:Application>

Screen shot on Chrome 2017-10-09_17-56-32

Harbs commented 7 years ago

What do you think the desired behavior should be? If the height is left out, the correct height seems to be correctly calculated.

justinmclean commented 7 years ago

Given there's a lot of white space between the rows it should be able to fit them in to about 1/2 that height. Perhaps if it gets too small and it can't fit them give some sort of warning.

pentapache commented 7 years ago

I confirmed this. I agree there is enough room to make the cells smaller and allow the DateChooser to be smaller.