apache / royale-asjs

Apache Royale ASJS
Apache License 2.0
372 stars 116 forks source link

Layout Properties should be fixed in Some Major Setups (High Priority) #637

Open pashminakazi opened 4 years ago

pashminakazi commented 4 years ago

Please Make these three setups layout same as Flex. I will be very Thankful to you. I have tried to fix layout of these setups but,I am unable to fix these setups Layout.Please help

Project Details are : https://paste.apache.org/cpo8y Test case is available on VDI. Go to Sales from Select in Menu Go to Documents -> Configure from Setups in Menu File : com/dbz/modules/Common/dbzDocumentTabSetup.mxml

dbzDocumentTabSetup is loading com/dbz/modules/Common/dbzDocumentSetup.mxml and com/dbz/modules/Common/dbzDocumentDetailSetup.mxml

In Flex : DocumentSetup

In Royale : image

Go to Sales from Select in Menu Go to Product -> Profile from Setups in Menu File : com/dbz/modules/Common/dbzProductProfileSetup.mxml

In Flex : productProfile

In Royale : image

Go to Sales from Select in Menu Go to Customer -> Profile from Setups in Menu File : com/dbz/modules/Common/dbzCustomerSetupTabs.mxml

dbzCustomerSetupTabs is loading com/dbz/modules/SAL/dbzCustomerSetup.mxml

In Flex : CustomerSetup

In Royale : image

aharui commented 4 years ago

Please be more specific about what differences need to be addressed

pashminakazi commented 4 years ago

Layout problems in these setups like Height,width,left, right,overflow Please make these setups layout like flex please

aharui commented 4 years ago

So is the issue that there are scrollbars in the Royale version?

pashminakazi commented 4 years ago

Yes scrollbars and some other issues related to layout. That height and width is fit on screen in flex in Royale some components on bottom is hidden from screen and scrollbars appear on screen then we scroll down to see those components.this is not right because everything height width left right is same as in flex and screen resolution is also same

pashminakazi commented 4 years ago

Please see layout problems in productprofile and customer setup.both pictures of setups is uploaded in this issue.flex vs royale setups

aharui commented 4 years ago

The browsers may have slightly different actual display area than Flash and one or two pixels can cause scrollbars to appear. Have you verified that the right container size is the same between Flex and Royale?

pashminakazi commented 4 years ago

In flex I can't inspect to see the width height of container If you can then I will send you VDI I'd password with flex code

aharui commented 4 years ago

How did your company debug their Flex app before deployment? Whatever technique was used you should find out and use it. The two most common techniques are to be able to build with the debug flag on, or add trace statements.

Another technique you can try for these purposes is to grab a screen capture and display it in Paint or some other drawing tool and look at the x,y of the mouse as you position the cursor over the borders of containers in the screen capture. This can be less accurate.

piotrzarzycki21 commented 4 years ago

In flex I can't inspect to see the width height of container If you can then I will send you VDI I'd password with flex code

There were two tools for inspecting Flex application FlexSpy and MonsterDebugger - I was using latter at least one year ago and it was working fine.

aharui commented 4 years ago

I just took a quick look at com/dbz/modules/Common/dbzDocumentTabSetup.mxml The TabNavigator has top="29", and if you look at the screenshots, you can see that there is a gap above the TabNavigator in the Royale version. Did the Flex version also have top="29"?

I changed that to 0 in the debugger and made the inner container taller by 29 and the vertical scrollbar went away. I added two pixels in width and the horizontal scrollbar went away. There may be a small difference in how borders or padding or margins are factored in for the Royale version.

Set top="0" and see if that helps and see if the other screens have a similar problem. I will go investigate other issues.

pashminakazi commented 4 years ago

Thanks Alex, dbzDocumentTabSetup layout is now like flex.

Go to Sales from Select in Menu Go to Customer -> Profile from Setups in Menu File : com/dbz/modules/Common/dbzCustomerSetupTabs.mxml But major layout problem is in productprofile and CustomerSetup..Please guide me about only one setup layout CustomerSetup.

Go to Sales from Select in Menu Go to Product -> Profile from Setups in Menu File : com/dbz/modules/Common/dbzProductProfileSetup.mxml In productProfileSetup overflow:hidden works but problem occurs when we go to another tab and came back to 1st tab.the save,undo,delete,new buttons are overlapped with LinkButtons on Bottom

In productProfileSetup TabNavigator top is already '0' Layout issue in ProductProfileSetup

aharui commented 4 years ago

For Product Profiles It appears that the Flex version was able to display the tabs on top of the Panel's title bar. I'm not sure if the Flex code is different or if Panel is supposed to allow that or if that's a bug, but having the tabs over the title bar probably explains the difference. You may need to adjust the sizes and positions so everything fits with less room.

aharui commented 4 years ago

You could try setting negative values for "top" to try to move the TabNavigator up over the Panel's TitleBar, but I don't think the rest of the sizes will compute properly.

aharui commented 4 years ago

I expect that CustomerSetupTabs has the same problem.