apache / sedona

A cluster computing framework for processing large-scale geospatial data
https://sedona.apache.org/
Apache License 2.0
1.96k stars 692 forks source link

[CI] Fix Connection time out in Python workflow #1651

Closed furqaankhan closed 3 weeks ago

furqaankhan commented 1 month ago

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

How was this patch tested?

Did this PR include necessary documentation updates?

furqaankhan commented 4 weeks ago

@jbampton @jiayuasu Not sure why the lint is not passing. It is passing on my fork's PR: https://github.com/furqaankhan/sedona/pull/2

jbampton commented 4 weeks ago

Hey @furqaankhan the requirements txt fixer hook is failing.

Basically docker/sedona-spark-jupyterlab/requirements.txt is not sorted.

I have the fix in #1654

jiayuasu commented 4 weeks ago

A quick example about global env from ChatGPT

name: Matrix CI Workflow

on: [push, pull_request]

jobs:
  build:
    runs-on: ubuntu-latest

    # Define a matrix of input values
    strategy:
      matrix:
        environment: [staging, production]
        node: [16, 18]

    # Use the matrix value inside `env`
    env:
      ENV_NAME: ${{ matrix.environment }}
      NODE_VERSION: ${{ matrix.node }}

    steps:
      - name: Check out repository
        uses: actions/checkout@v3

      - name: Print Matrix Inputs as Environment Variables
        run: |
          echo "Environment: $ENV_NAME"
          echo "Node Version: $NODE_VERSION"

      - name: Use Environment-Specific Logic
        run: |
          if [ "$ENV_NAME" == "production" ]; then
            echo "This is a production build.";
          else
            echo "This is a staging build.";
          fi
jiayuasu commented 3 weeks ago

Great work!