apache / servicecomb-pack

Apache ServiceComb Pack is an eventually data consistency solution for micro-service applications. ServiceComb Pack currently provides TCC and Saga distributed transaction co-ordination solutions by using Alpha as a transaction coordinator and Omega as an transaction agent .
https://servicecomb.apache.org/
Apache License 2.0
1.93k stars 436 forks source link

[SCB-2238] FSM event channel supports Rabbit #691

Closed githubcheng2978 closed 3 years ago

githubcheng2978 commented 3 years ago

686

githubcheng2978 commented 3 years ago

@WillemJiang 麻烦看看我这个PR哪里还有问题呢

coolbeevip commented 3 years ago

I trigger CI run via reopening this issue

githubcheng2978 commented 3 years ago

I trigger CI run via reopening this issue

so what should i do to resolve this problem

coolbeevip commented 3 years ago

I trigger CI run via reopening this issue

so what should i do to resolve this problem

We just migrated CI from Travis to Github Action, your PR has been pass CI.

You need to modify the code according to William's suggestion and push it to githubcheng2978:feature-rabbitmq again

githubcheng2978 commented 3 years ago

William's

githubcheng2978 commented 3 years ago

I trigger CI run via reopening this issue

so what should i do to resolve this problem

We just migrated CI from Travis to Github Action, your PR has been pass CI.

You need to modify the code according to William's suggestion and push it to githubcheng2978:feature-rabbitmq again

ok , thanks for you help. i already finished it

githubcheng2978 commented 3 years ago

@coolbeevip 什么时候可以merge 啊

WillemJiang commented 3 years ago

@WillemJiang 麻烦看看我这个PR哪里还有问题呢

我看代码你把rabbitmq的客户端代码引入到Alpha server 的环境中来了,如果用户没有使用rabbitmq的话,是不是会报系统连接不上的信息。为了避免这个副作用,建议把RabbitMQ的配置文件从main/resources 去除。 另外如果能附上验收测试就更好了。

coolbeevip commented 3 years ago

I created a JIRA https://issues.apache.org/jira/browse/SCB-2238 for this PR

coolbeevip commented 3 years ago

@coolbeevip 什么时候可以merge 啊

方便的话,你可以给我发个邮件 coolbeevip@gmail.com, 我们交换一下微信

githubcheng2978 commented 3 years ago

@WillemJiang 麻烦看看我这个PR哪里还有问题呢

我看代码你把rabbitmq的客户端代码引入到Alpha server 的环境中来了,如果用户没有使用rabbitmq的话,是不是会报系统连接不上的信息。为了避免这个副作用,建议把RabbitMQ的配置文件从main/resources 去除。 另外如果能附上验收测试就更好了。

已经把RabbitMQ的配置文件从main/resources 移除掉了。