apache / shardingsphere-elasticjob

Distributed scheduled job
Apache License 2.0
8.09k stars 3.28k forks source link

move zkRegCenter.init() and zkRegCenter.close() to @BeforeAll and @AfterAll to make tests run faster and look similar to other tests #2378

Closed TestBoost closed 6 months ago

TestBoost commented 6 months ago

Changes proposed in this pull request:

TestBoost commented 6 months ago

Sorry for the checkstyle issues. I tried to run with ./mvnw spotless:apply -Pcheck -T1C and ./mvnw checkstyle:check -Pcheck -T1C, but it all passes. But when I checked the log, I found there is a tab in the changed test class file. I just changed it to whitespace and do not know if it works now.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a8ba448) 80.10% compared to head (98bf060) 79.61%. Report is 23 commits behind head on master.

Files Patch % Lines
.../rdb/storage/repository/RDBJobEventRepository.java 91.04% 3 Missing and 3 partials :warning:
.../tracing/rdb/storage/sql/SQLPropertiesFactory.java 71.42% 1 Missing and 1 partial :warning:
...here/elasticjob/http/executor/HttpJobExecutor.java 95.45% 0 Missing and 1 partial :warning:
...ing/rdb/config/RDBTracingStorageConfiguration.java 66.66% 0 Missing and 1 partial :warning:
...e/type/impl/DefaultTracingStorageDatabaseType.java 0.00% 1 Missing :warning:
.../tracing/rdb/yaml/YamlDataSourceConfiguration.java 0.00% 1 Missing :warning:
...rdb/yaml/YamlDataSourceConfigurationConverter.java 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2378 +/- ## ============================================ - Coverage 80.10% 79.61% -0.50% + Complexity 1113 1106 -7 ============================================ Files 204 204 Lines 3821 3806 -15 Branches 445 443 -2 ============================================ - Hits 3061 3030 -31 - Misses 570 585 +15 - Partials 190 191 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.