Closed TestBoost closed 6 months ago
Sorry for the checkstyle issues. I tried to run with ./mvnw spotless:apply -Pcheck -T1C
and ./mvnw checkstyle:check -Pcheck -T1C
, but it all passes. But when I checked the log, I found there is a tab
in the changed test class file. I just changed it to whitespace
and do not know if it works now.
Attention: 13 lines
in your changes are missing coverage. Please review.
Comparison is base (
a8ba448
) 80.10% compared to head (98bf060
) 79.61%. Report is 23 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request:
zkRegCenter.init();
andzkRegCenter.close();
into the method body of@BeforeAll
and@AfterAll
. There are three tests in the test classOneOffJobBootstrapTest
. However, these three tests are justing trying to usezkRegCenter
to initialize some objects and they are not modifyingzkRegCenter
.zkRegCenter.init();
andzkRegCenter.close();
. All tests in the projectapache/shardingsphere-elasticjob
exceptOneOffJobBootstrapTest
putzkRegCenter.init();
andzkRegCenter.close();
into the method body of@BeforeAll
and@AfterAll
.3.489 s
to2.403 s
after applying the changes when run on our machine.