apache / shardingsphere-on-cloud

A collection of tools and best practices to take ShardingSphere into the cloud
Apache License 2.0
83 stars 28 forks source link

feat: storage node support register and unregsiter for aws aurora cluster #398

Closed Xu-Wentao closed 1 year ago

Xu-Wentao commented 1 year ago

Type of change:

What this PR does / why we need it:

Pre-submission checklist:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 1 year ago

Codecov Report

Merging #398 (8c5509b) into main (e52f093) will decrease coverage by 5.78%. The diff coverage is 12.35%.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   47.34%   41.56%   -5.78%     
==========================================
  Files          48       51       +3     
  Lines        5264     6257     +993     
==========================================
+ Hits         2492     2601     +109     
- Misses       2547     3418     +871     
- Partials      225      238      +13     
Impacted Files Coverage Δ
pitr/agent/internal/handler/backup.go 15.00% <ø> (ø)
pitr/agent/internal/handler/restore.go 0.00% <ø> (ø)
pitr/agent/internal/handler/show.go 0.00% <ø> (ø)
pitr/agent/internal/pkg/opengauss.go 3.93% <ø> (ø)
pitr/agent/internal/pkg/pkg.go 0.00% <ø> (ø)
pitr/agent/pkg/cmds/cmd.go 49.46% <ø> (ø)
pitr/agent/pkg/gsutil/conn.go 29.41% <ø> (ø)
pitr/agent/pkg/strutil/rand_string.go 90.90% <ø> (ø)
pitr/agent/pkg/xerror/error.go 61.53% <ø> (ø)
pitr/cli/internal/cmd/backup.go 73.47% <0.00%> (ø)
... and 26 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

wbtlb commented 1 year ago

approve

mlycore commented 1 year ago

ref #271