apache / shardingsphere-on-cloud

A collection of tools and best practices to take ShardingSphere into the cloud
Apache License 2.0
83 stars 29 forks source link

refactor(operator): optimize storage node status in CNPG #410

Closed mlycore closed 1 year ago

mlycore commented 1 year ago

Type of change:

What this PR does / why we need it:

Pre-submission checklist:

codecov-commenter commented 1 year ago

Codecov Report

Merging #410 (ab644a2) into main (3604a24) will decrease coverage by 1.76%. The diff coverage is 3.70%.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   39.71%   37.96%   -1.76%     
==========================================
  Files          51       52       +1     
  Lines        6083     6406     +323     
==========================================
+ Hits         2416     2432      +16     
- Misses       3448     3744     +296     
- Partials      219      230      +11     
Impacted Files Coverage Δ
...tor/cmd/shardingsphere-operator/manager/manager.go 0.00% <0.00%> (ø)
...ator/cmd/shardingsphere-operator/manager/option.go 49.53% <0.00%> (ø)
...phere-operator/pkg/controllers/chaos_controller.go 0.00% <0.00%> (ø)
...gsphere-operator/pkg/kubernetes/service/builder.go 76.92% <ø> (ø)
...e-operator/pkg/reconcile/storagenode/aws/aurora.go 17.94% <0.00%> (-0.24%) :arrow_down:
...here-operator/pkg/reconcile/storagenode/aws/aws.go 0.00% <ø> (ø)
...erator/pkg/reconcile/storagenode/aws/rdscluster.go 0.00% <0.00%> (ø)
...perator/pkg/controllers/storage_node_controller.go 53.51% <16.26%> (-8.92%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

mlycore commented 1 year ago

ref #271