apache / shardingsphere-on-cloud

A collection of tools and best practices to take ShardingSphere into the cloud
Apache License 2.0
83 stars 29 forks source link

fix: delete backup file when backup failed. #413

Closed Xu-Wentao closed 1 year ago

Xu-Wentao commented 1 year ago

Type of change:

What this PR does / why we need it:

Pre-submission checklist:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

codecov-commenter commented 1 year ago

Codecov Report

Merging #413 (e4c7276) into main (3604a24) will decrease coverage by 1.21%. The diff coverage is 4.77%.

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   39.71%   38.51%   -1.21%     
==========================================
  Files          51       52       +1     
  Lines        6083     6424     +341     
==========================================
+ Hits         2416     2474      +58     
- Misses       3448     3721     +273     
- Partials      219      229      +10     
Impacted Files Coverage Δ
pitr/agent/internal/handler/restore.go 0.00% <0.00%> (ø)
pitr/cli/internal/cmd/restore.go 58.33% <0.00%> (-0.99%) :arrow_down:
pitr/cli/internal/pkg/local-storage.go 40.65% <0.00%> (-2.09%) :arrow_down:
...tor/cmd/shardingsphere-operator/manager/manager.go 0.00% <0.00%> (ø)
...ator/cmd/shardingsphere-operator/manager/option.go 49.53% <0.00%> (ø)
...phere-operator/pkg/controllers/chaos_controller.go 0.00% <0.00%> (ø)
...gsphere-operator/pkg/kubernetes/service/builder.go 76.92% <ø> (ø)
...e-operator/pkg/reconcile/storagenode/aws/aurora.go 17.94% <0.00%> (-0.24%) :arrow_down:
...here-operator/pkg/reconcile/storagenode/aws/aws.go 0.00% <ø> (ø)
...erator/pkg/reconcile/storagenode/aws/rdscluster.go 0.00% <0.00%> (ø)
... and 4 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

wbtlb commented 1 year ago

approve