apache / shardingsphere-on-cloud

A collection of tools and best practices to take ShardingSphere into the cloud
Apache License 2.0
83 stars 29 forks source link

refactor(operator): split DeploymentBuilder #429

Closed mlycore closed 1 year ago

mlycore commented 1 year ago

Type of change:

What this PR does / why we need it:

Pre-submission checklist:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

codecov-commenter commented 1 year ago

Codecov Report

Merging #429 (a2f00b0) into main (3604a24) will decrease coverage by 1.97%. The diff coverage is 24.24%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   39.71%   37.75%   -1.97%     
==========================================
  Files          51       53       +2     
  Lines        6083     6617     +534     
==========================================
+ Hits         2416     2498      +82     
- Misses       3448     3891     +443     
- Partials      219      228       +9     
Impacted Files Coverage Δ
pitr/agent/internal/handler/restore.go 0.00% <0.00%> (ø)
pitr/cli/internal/cmd/restore.go 58.33% <0.00%> (-0.99%) :arrow_down:
pitr/cli/internal/pkg/local-storage.go 40.65% <0.00%> (-2.09%) :arrow_down:
...tor/cmd/shardingsphere-operator/manager/manager.go 0.00% <0.00%> (ø)
...phere-operator/pkg/controllers/chaos_controller.go 0.00% <0.00%> (ø)
...rdingsphere-operator/pkg/kubernetes/pod/builder.go 0.00% <0.00%> (ø)
...gsphere-operator/pkg/kubernetes/service/builder.go 76.92% <ø> (ø)
...e-operator/pkg/reconcile/storagenode/aws/aurora.go 17.94% <0.00%> (-0.24%) :arrow_down:
...here-operator/pkg/reconcile/storagenode/aws/aws.go 0.00% <ø> (ø)
...erator/pkg/reconcile/storagenode/aws/rdscluster.go 0.00% <0.00%> (ø)
... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more