search

apache / shardingsphere

Distributed SQL transaction & query engine for data sharding, scaling, encryption, and more - on any database.
Apache License 2.0
19.88k stars 6.73k forks source link

Introduce `flatten-maven-plugin` for ShardingSphere #21639

Closed RaigorJiang closed 1 year ago

RaigorJiang commented 2 years ago

Hi community,

Now the subproject examples has used the flatten-maven-plugin to reduce duplicate version declarations (since https://github.com/apache/shardingsphere/issues/13512). It is valuable, otherwise we still have to change a lot of version numbers during release (like this https://github.com/apache/shardingsphere/pull/21625)

Therefore, I am going to use ${revision} to define the version number in the same way for ShardingSphere, to facilitate maintenance.

TeslaCN commented 2 years ago

If we did this, should we change usage of maven-release-plugin?

TeslaCN commented 2 years ago

https://github.com/apache/shardingsphere/issues/15531

RaigorJiang commented 2 years ago

Hi @TeslaCN Thanks for your reminder, maven-release-plugin can help reduce the trouble in the release process, but in daily development, if I add a new module, I still have to add a displayed version number, which still has the risk of error.

I will investigate the possibility of using flatten-maven-plugin and maven-release-plugin together.

TeslaCN commented 1 year ago

Hi @RaigorJiang Please confirm the milestone of this issue.

RaigorJiang commented 1 year ago

Hi @RaigorJiang Please confirm the milestone of this issue.

Hi @TeslaCN , It can't be finished soon, I just remove the milestone.

RaigorJiang commented 1 year ago

I think this issue is no longer necessary, I will close it.