search

apache / shenyu-client-golang

Apache ShenYu Client SDK for golang.
https://shenyu.apache.org/
Apache License 2.0
15 stars 12 forks source link

[Fix: Supports namespaceId.] #49

Closed koonchen closed 3 days ago

koonchen commented 1 week ago

48

image
koonchen commented 1 week ago

@moremind Can you run ci again? Personal project ci passed. https://github.com/koonchen/shenyu-client-golang/pull/2

lishuo5263 commented 1 week ago

pls change your code,about nacos namespaceId(param named like NameSpaceId), the nacos source code is use "public"

image
koonchen commented 1 week ago

I'm not sure if this is correct, PTAL @lishuo5263

koonchen commented 6 days ago

@moremind PTAL

codecov-commenter commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (10938f5) to head (0ab0a0b). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
example/consul_client/consul_client.go 0.00% 21 Missing :warning:
example/zk_client/zk_client.go 0.00% 18 Missing :warning:
example/etcd_client/etcd_client.go 0.00% 12 Missing :warning:
example/nacos_client/nacos_client.go 0.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 2 4 +2 Lines 186 385 +199 ====================================== - Misses 186 385 +199 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: