search

apache / shenyu-website

Apache ShenYu website.
https://shenyu.apache.org/
Apache License 2.0
74 stars 221 forks source link

[ISSUE #931] Correcting the blog SPI source code analysis #930

Closed PraveenGowthaman closed 1 year ago

PraveenGowthaman commented 1 year ago

Hi Team,

Just came across this blog SPI source code analysis where the author has done a excellent job in explaining shenyu's SPI module.

However when I first read it , the service provider interface explanation and few other paragraph felt little confusing . So I have corrected them and submitted it in this PR.

Hopefully this helps other new learners like me .

Kindly review it and let me know if it is ok to change it or not ?

Task List

Corrected SPI explanation as it was little confusing Corrected few code examples Corrected few grammar since it was little confusing

Thanks and regards, Praveen G

yu199195 commented 1 year ago

@PraveenGowthaman hi，thanks contributor for you，its good to me，but you can checked ci error.

PraveenGowthaman commented 1 year ago

@PraveenGowthaman hi，thanks contributor for you，its good to me，but you can checked ci error.

Hi @yu199195 ,

I have added space before and after the code blocks now. Could u kindly retrigger the CI .

Thanks and regards, Praveen