apache / shenyu

Apache ShenYu is a Java native API Gateway for service proxy, protocol conversion and API governance.
https://shenyu.apache.org/
Apache License 2.0
8.44k stars 2.93k forks source link

The config shenyu > client > props > port is duplicate with spring server.port config #1731

Closed fixwater closed 2 years ago

fixwater commented 3 years ago

Feature Request

Is your feature request related to a problem? Please describe

In docs (https://shenyu.apache.org/zh/projects/shenyu/register-center-access/) when access zookeeper , a springmvc(springboot) client have to config

shenyu:
  client:
    registerType: zookeeper
    serverLists: localhost:2181
    props:
      contextPath: /http
      appName: http
      port: 8188  
      isFull: false

The config shenyu > client > props > port is duplicate with spring server.port config

Describe the solution you'd like

need not config 【shenyu > client > props > port】 config , just reuse spring server.port config as port value

Describe alternatives you've considered

Additional context

KevinClair commented 3 years ago

Hello, it is a good idea, can you submit pull request ? we will review it.

zhaiweij commented 3 years ago

Hello, it is a good idea, can you submit pull request ? we will review it.

I go to improve this