search

apache / shenyu

Apache ShenYu is a Java native API Gateway for service proxy, protocol conversion and API governance.
https://shenyu.apache.org/
Apache License 2.0
8.41k stars 2.92k forks source link

[BUG] No handler field for custom plugin in shenyu-admin #2165

Closed ichenhe closed 2 years ago

ichenhe commented 2 years ago

Is there an existing issue for this?

Current Behavior

There's no handler field for custom plugin in shenyu-admin. (Docker version: apache/shenyu-admin)

Expected Behavior

According to the document, there should be a handler field to accept custom json data for custom plugin.

Steps To Reproduce

In shenyu-admin web:

  1. Add a plugin.
  2. Add a rule.
  3. No handler field.

Environment

ShenYu version(s): 2.4.0 docker

Debug logs

N/A

Anything else?

No response

qicz commented 2 years ago

the "handler" is just in selector configuation. and the custom plugin should be put to the plugin database table.

ichenhe commented 2 years ago

OK, when I reconfirmed the setting, I stumbled upon the problem.

There's a new configuration in Admin - BasicConfig called PluginHandle. We need to specify the data schema here. It's great, so it's type-safe.

But the document was not updated, I will push a PR to improve it.

ichenhe commented 2 years ago

Redirect to apache/incubator-shenyu-website