search

apache / shenyu

Apache ShenYu is a Java native API Gateway for service proxy, protocol conversion and API governance.
https://shenyu.apache.org/
Apache License 2.0
8.44k stars 2.93k forks source link

[Question] How about adding an `IsolatePlugin` ? #2886

Closed loongs-zhang closed 2 years ago

loongs-zhang commented 2 years ago

Question

With the increasing application of accessing ShenYu, hot applications and non hot applications will interact with each other, resulting in the problem of application avalanche.

To solve this problem, IsolatePlugin is introduced to isolate shenyu-bootstrap resources(such as memory, threads, etc).

Only thread pool resource is supported for the first version.

yu199195 commented 2 years ago

@dragon-zhang whats mean to protection shenyu？

loongs-zhang commented 2 years ago

When facing great pressure, it can make shenyu-bootstrap run more stably.

yu199195 commented 2 years ago

When facing great pressure, it can make shenyu-bootstrap run more stably.

Is there any difference between the hystrix plugin and resilience4j plugin~

loongs-zhang commented 2 years ago

These two plugins do not distinguish traffic, the traffic of hot applications can be affected by the traffic of non hot applications.

发自我的iPhone

------------------ Original ------------------ From: xiaoyu @.> Date: Wed,Feb 16,2022 6:14 PM To: apache/incubator-shenyu @.> Cc: dragon-zhang @.>, Mention @.> Subject: Re: [apache/incubator-shenyu] [Question] How about adding an IsolatePlugin ? (Issue #2886)

When facing great pressure, it can make shenyu-bootstrap run more stably.

Is there any difference between the hystrix plugin and resilience4j plugin~

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>

yu199195 commented 2 years ago

@dragon-zhang

you can send eamil to dev@shenyu.apache.org, And Explain the principle and the solution，

Looking forward to your contribution~

loongs-zhang commented 2 years ago

@dragon-zhang

you can send eamil to dev@shenyu.apache.org, And Explain the principle and the solution，

Looking forward to your contribution~

Sure, I will do it as soon as possible.

loongs-zhang commented 2 years ago

After reading Concurrent Thread count in https://sentinelguard.io/en-us/docs/flow-control.html carefully, I realize that SentinelPlugin has provided good support for this, and there is no need to add IsolatePlugin, so I will close this issue.